SDK-2482: Support dark mode in IDV SDK #490
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement the new properties for configuring dark mode in the IDV Web SDK, follow this detailed implementation plan. The plan breaks down the tasks into manageable steps necessary to complete the feature from start to finish.
Step-by-Step Implementation Plan:
Step 1: Update the SdkConfig Object Model
Task 1.1: Add New Properties
dark_mode
as a property of theSdkConfig
object model.primary_colour_dark_mode
as a property of theSdkConfig
object model.Task 1.2: Modify Builders
SdkConfig
to include methods for setting these two new properties. Make sure methods are chainable to maintain current builder pattern consistency.Step 2: Implement Helper Methods
dark_mode
setDarkModeOn()
that sets thedark_mode
to "ON".setDarkModeOff()
that sets thedark_mode
to "OFF".setDarkModeAuto()
that sets thedark_mode
to "AUTO".Step 3: Modify JSON Serialization
dark_mode
andprimary_colour_dark_mode
are only included in the JSON payload if they are set by the Relying Business.Step 4: Testing
Task 4.1: Unit Testing
dark_mode
appropriately in theSdkConfig
object.Task 4.2: Integration Testing
Step 5: Documentation
dark_mode
andprimary_colour_dark_mode
.Step 6: Code Review and Deployment
Task 6.1: Peer Code Review
Task 6.2: Prepare for Deployment
This implementation plan outlines the necessary steps to integrate and support the new dark mode configuration, ensuring a smooth development process and compliance with existing system architecture.